(941) Hide details if there is no change history #9985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
content-modelling/941-empty-details-of-changes-in-change-history
branch
from
cc76dff to
12c3c6e
Compare
Sometimes change history can be present, but doesn’t have items within it. To get around this, we move the logic to the component and only render the details if there are any details rendered. Additionally, I’ve changed the version factory to build, rather than create so we don’t have to create versions in the database unneccessarily
pezholio
force-pushed
the
content-modelling/941-empty-details-of-changes-in-change-history
branch
from
12c3c6e to
d84dec8
Compare
pezholio
deleted the
content-modelling/941-empty-details-of-changes-in-change-history
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/REP99FWH/941-empty-details-of-changes-in-change-history
Sometimes change history can be present, but doesn’t have items within it. To get around this, we move the logic to the component and only render the details if there are any details rendered.
Additionally, I’ve changed the version factory to build, rather than create so we don’t have to create versions in the database unnecessarily